Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override req host from header #219

Merged
merged 1 commit into from
Jul 17, 2023
Merged

override req host from header #219

merged 1 commit into from
Jul 17, 2023

Conversation

kenanfarukcakir
Copy link
Contributor

Pull Request Template

Type of Change

Please check the relevant boxes by putting an "x" in the appropriate box.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Description

Given Host header was not taken into account while sending request. Host was taken from steps URL.
With this change Host header will be taken into account, and will override the actual requests host.

Related Issue(s)

#218.

Checklist

Please go through this checklist and make sure all applicable tasks have been done.

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the README.md as necessary if there are changes.
  • I have tested the changes on my local machine before submitting the PR.

Screenshots

If applicable, please provide screenshots, video or GIF to help demonstrate the changes.

@ddosifyadmin
Copy link

Max. Delta Time op: 0.76 / 15
Max. Delta Alloc op: 5.63 / 15
Max. Delta Allocs op: 0.83 / 15

@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Merging #219 (68ed906) into develop (c0503ac) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #219      +/-   ##
===========================================
+ Coverage    81.76%   81.77%   +0.01%     
===========================================
  Files           37       37              
  Lines         5192     5195       +3     
===========================================
+ Hits          4245     4248       +3     
  Misses         766      766              
  Partials       181      181
Impacted Files Coverage Δ
core/scenario/requester/http.go 84.71% <100.00%> (+0.06%) ⬆️

@fatihbaltaci fatihbaltaci merged commit 7335ce7 into develop Jul 17, 2023
@fatihbaltaci fatihbaltaci deleted the fix/host-override branch July 17, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatihbaltaci fatihbaltaci fatihbaltaci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenanfarukcakir @ddosifyadmin @fatihbaltaci